Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: OauthTokenExchangeHandler, ActionableEventOrchDef, ActionableEventTypeDef, OmniExtTrackingDef #1241

Merged
merged 7 commits into from
Feb 21, 2024

Conversation

mshanemc
Copy link
Contributor

What does this PR do?

adds 4 new mdTypes

the whole registry is now sorted json (previously, it was kinda chronological?).

That caused some other required changes to UT that depended on the existing order. (deep.equal => deep.equalInAnyOrder)

@mshanemc mshanemc requested a review from a team as a code owner February 21, 2024 13:52
@mshanemc mshanemc changed the title feat: OauthTokenExchangeHandler, feat: OauthTokenExchangeHandler, ActionableEventOrchDef, ActionableEventTypeDef, OmniExtTrackingDef Feb 21, 2024
Copy link
Member

@cristiand391 cristiand391 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what enforces the registry to be sorted in the future? don't see any prettier change here.

@cristiand391 cristiand391 merged commit 1423b76 into main Feb 21, 2024
69 of 71 checks passed
@cristiand391 cristiand391 deleted the sm/v60-mdTypes branch February 21, 2024 14:46
@mshanemc
Copy link
Contributor Author

what enforces the registry to be sorted in the future? don't see any prettier change here.

nothing. People can keep it sorted if they want to, but it doesn't cause errors if not sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants