fix: defend against bad mdapi responses #1236
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
handles
undefined
being passsed to a method that expects strings. It'd be better if all the consumers of this warned which component was missing its filename in the MDAPI reponse, but this at least prevents the unhelpful error.How'd this get by us? The mdapi response isn't matching its expected typing. I'm guessing that's a server bug related to the new release, but am waiting for the full
deployResult
so I can inspect its contents. One of the DeployMessage is unexpectedly missing thefileName
property.ex: forcedotcom/cli#2697
also got a report of this happening on
push
What issues does this PR fix or reference?
#, @@
Functionality Before
<insert gif and/or summary>
Functionality After
<insert gif and/or summary>