feat!: component set components are now DecodableMaps #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
approved these changes
Aug 15, 2023
src/collections/componentSet.ts
Outdated
Comment on lines
110
to
114
| for (const compKey of this.keys()) { | ||
| if (decodeURIComponent(compKey) === decodeURIComponent(key)) { | ||
| return compKey; | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const compKey of this.keys()) { | |
| if (decodeURIComponent(compKey) === decodeURIComponent(key)) { | |
| return compKey; | |
| } | |
| } | |
| return this.keys().find((compKey) => decodeURIComponent(compKey) === decodeURIComponent(key)) |
There was a problem hiding this comment.
this.keys() returns an IterableIterator<string> so find() isn't available.
There was a problem hiding this comment.
this.keys() returns an IterableIterator so find() isn't available.
you can call Array.from() on those to get a real array.
return Array.from(this.keys()).find((compKey) => decodeURIComponent(compKey) === decodeURIComponent(key))
|
QA is here: forcedotcom/source-tracking#458 |
|
Approved for release. |
shetzel
added a commit
that referenced
this pull request
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Creates a new DecodeableMap class that extends the standard Map. A DecodableMap is the same as a Map except that the key must be a string, and whenever passing a key it will match on the exact text and the decoded text. Since
ComponentSet.componentsMaps use component fullNames as keys, this allows encoded fullNames to match decoded fullNames, and vice versa.What issues does this PR fix or reference?
@W-11658886@