Skip to content

Commit

Permalink
chore: represent CFT as COTs because CFT isn't a real type, and can't…
Browse files Browse the repository at this point in the history
… be pushed after a local change
  • Loading branch information
WillieRuemmele committed Oct 19, 2023
1 parent 2d04133 commit 792e959
Showing 1 changed file with 12 additions and 4 deletions.
16 changes: 12 additions & 4 deletions src/resolve/adapters/decomposedSourceAdapter.ts
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,18 @@ export class DecomposedSourceAdapter extends MixedContentSourceAdapter {
!component &&
this.type.children.types[childTypeId].unaddressableWithoutParent
) {
// if we're parsing an unaddressableWithoutParent type, and there's no component for it
// it's likely that the parent resides outside of the current package we're building
// e.g. a COT in a managed package, with the COFT in a different package
// so we'll address the child as a parent
/*
if we're parsing an unaddressableWithoutParent type, and there's no component for it, then it's likely that the parent resides outside the current package we're building
e.g. a COT in a managed package, with the COFT in a different package, so we'll address the child as a parent so that the two will be built together
this will result in a incorrect type being displayed
STATE FULL NAME TYPE PROJECT PATH
─────── ────────────────── ─────────────────────── ─────────────────────────────────────────────────────────────────────────────────────────
Changed customObject__c-es CustomObjectTranslation ...default/objectTranslations/customObject__c-es/customField__c.fieldTranslation-meta.xml
notice how it says CustomObjectTranslation even though the suffix is a .fieldTranslation
*/
return new SourceComponent(
{
name: baseName(pathToContent),
Expand Down

2 comments on commit 792e959

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 792e959 Previous: 9761f1a Ratio
eda-componentSetCreate-linux 270 ms 264 ms 1.02
eda-sourceToMdapi-linux 7001 ms 6830 ms 1.03
eda-sourceToZip-linux 5704 ms 5283 ms 1.08
eda-mdapiToSource-linux 4003 ms 3640 ms 1.10
lotsOfClasses-componentSetCreate-linux 659 ms 615 ms 1.07
lotsOfClasses-sourceToMdapi-linux 10153 ms 9118 ms 1.11
lotsOfClasses-sourceToZip-linux 8572 ms 7840 ms 1.09
lotsOfClasses-mdapiToSource-linux 4645 ms 4116 ms 1.13
lotsOfClassesOneDir-componentSetCreate-linux 937 ms 852 ms 1.10
lotsOfClassesOneDir-sourceToMdapi-linux 12858 ms 11270 ms 1.14
lotsOfClassesOneDir-sourceToZip-linux 12930 ms 11232 ms 1.15
lotsOfClassesOneDir-mdapiToSource-linux 8443 ms 7165 ms 1.18

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 792e959 Previous: 9761f1a Ratio
eda-componentSetCreate-win32 634 ms 493 ms 1.29
eda-sourceToMdapi-win32 10380 ms 9712 ms 1.07
eda-sourceToZip-win32 7267 ms 6183 ms 1.18
eda-mdapiToSource-win32 9772 ms 7901 ms 1.24
lotsOfClasses-componentSetCreate-win32 1381 ms 1101 ms 1.25
lotsOfClasses-sourceToMdapi-win32 16529 ms 15114 ms 1.09
lotsOfClasses-sourceToZip-win32 11535 ms 9965 ms 1.16
lotsOfClasses-mdapiToSource-win32 11992 ms 9926 ms 1.21
lotsOfClassesOneDir-componentSetCreate-win32 2321 ms 1864 ms 1.25
lotsOfClassesOneDir-sourceToMdapi-win32 26820 ms 23238 ms 1.15
lotsOfClassesOneDir-sourceToZip-win32 18368 ms 15980 ms 1.15
lotsOfClassesOneDir-mdapiToSource-win32 21422 ms 17891 ms 1.20

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.