chore: modify workflows to skip publish upon beta release

forcedotcom · Aug 27, 2024 · 6c2be7d · 6c2be7d · svc-cli-bot · Aug 27, 2024
1 parent d100d2d
commit 6c2be7d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 7 deletions.
diff --git a/.github/workflows/onRelease.yml b/.github/workflows/onRelease.yml
@@ -29,3 +29,11 @@ jobs:
       githubTag: ${{ github.event.release.tag_name || inputs.tag }}
 
     secrets: inherit
+
+  publish-bundle:
+    if: ${{ success() && needs.getDistTag.outputs.tag != 'beta' }}
+    uses: ./.github/workflows/releaseWithCoreBundle.yml
+    needs: [getDistTag, npm]
+    with:
+      branch: 'main'
+    secrets: inherit
diff --git a/.github/workflows/releaseWithCoreBundle.yml b/.github/workflows/releaseWithCoreBundle.yml
@@ -1,10 +1,12 @@
 name: publish source-deploy-retrieve-bundle
 on:
-  workflow_run:
-    workflows:
-      - publish
-    types:
-      - completed
+  workflow_call:
+    inputs:
+      branch:
+        description: 'Set the branch to use for release'
+        type: string
+        required: false
+        default: 'main'
   workflow_dispatch:
     inputs:
       branch:
@@ -15,8 +17,8 @@ on:
 
 jobs:
   call-release-workflow:
-    if: ${{ inputs.branch || (github.event_name == 'workflow_run' && github.event.workflow_run.conclusion == 'success')}}
+    if: ${{ inputs.branch }}
     uses: forcedotcom/bundle-publish-scripts/.github/workflows/releaseWithCoreBundle.yml@main
     secrets: inherit
     with:
-      branch: ${{ inputs.branch || 'main' }}
+      branch: ${{ inputs.branch }}
Benchmark suite	Current: `6c2be7d`	Previous: `8c68696`	Ratio
`eda-componentSetCreate-linux`	`244` ms	`237` ms	`1.03`
`eda-sourceToMdapi-linux`	`2230` ms	`2295` ms	`0.97`
`eda-sourceToZip-linux`	`1863` ms	`1933` ms	`0.96`
`eda-mdapiToSource-linux`	`2925` ms	`2933` ms	`1.00`
`lotsOfClasses-componentSetCreate-linux`	`432` ms	`435` ms	`0.99`
`lotsOfClasses-sourceToMdapi-linux`	`3754` ms	`3836` ms	`0.98`
`lotsOfClasses-sourceToZip-linux`	`3036` ms	`3206` ms	`0.95`
`lotsOfClasses-mdapiToSource-linux`	`3563` ms	`3659` ms	`0.97`
`lotsOfClassesOneDir-componentSetCreate-linux`	`749` ms	`748` ms	`1.00`
`lotsOfClassesOneDir-sourceToMdapi-linux`	`6435` ms	`6529` ms	`0.99`
`lotsOfClassesOneDir-sourceToZip-linux`	`5560` ms	`5671` ms	`0.98`
`lotsOfClassesOneDir-mdapiToSource-linux`	`6594` ms	`6374` ms	`1.03`
Benchmark suite	Current: `6c2be7d`	Previous: `8c68696`	Ratio
`eda-componentSetCreate-win32`	`625` ms	`616` ms	`1.01`
`eda-sourceToMdapi-win32`	`4252` ms	`4311` ms	`0.99`
`eda-sourceToZip-win32`	`2935` ms	`2974` ms	`0.99`
`eda-mdapiToSource-win32`	`5685` ms	`5719` ms	`0.99`
`lotsOfClasses-componentSetCreate-win32`	`1209` ms	`1246` ms	`0.97`
`lotsOfClasses-sourceToMdapi-win32`	`7765` ms	`7704` ms	`1.01`
`lotsOfClasses-sourceToZip-win32`	`5249` ms	`5029` ms	`1.04`
`lotsOfClasses-mdapiToSource-win32`	`7706` ms	`7763` ms	`0.99`
`lotsOfClassesOneDir-componentSetCreate-win32`	`2103` ms	`2109` ms	`1.00`
`lotsOfClassesOneDir-sourceToMdapi-win32`	`13688` ms	`13899` ms	`0.98`
`lotsOfClassesOneDir-sourceToZip-win32`	`9160` ms	`9369` ms	`0.98`
`lotsOfClassesOneDir-mdapiToSource-win32`	`14061` ms	`14075` ms	`1.00`