chore: cleanup snapshots

forcedotcom · Jun 11, 2024 · 1a86def · 1a86def · svc-cli-bot · Jun 11, 2024
1 parent a3542e2
commit 1a86def
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 43 deletions.
diff --git a/src/convert/transformers/decomposedMetadataTransformer.ts b/src/convert/transformers/decomposedMetadataTransformer.ts
@@ -206,6 +206,10 @@ const getWriteInfosWithoutMerge =
   (parentXmlObject: XmlObj) =>
   (component: SourceComponent): WriteInfo[] => {
     const output = join(defaultDirectory ?? '', getOutputFile(component));
+    // if the parent would be empty
+    // and it exists
+    // and every child is addressable
+    // don't overwrite the existing parent
     if (
       !objectHasSomeRealValues(component.type)(parentXmlObject) &&
       fs.existsSync(output) &&
@@ -220,8 +224,7 @@ const getWriteInfosWithoutMerge =
 /**
  * Helper for setting the decomposed transaction state
  *
- * @param forComponent
- * @param props
+ * @param state
  */
 const setDecomposedState =
   (state: DecompositionState) =>

diff --git a/...Projects/mpdWithLabels/__snapshots__/verify-md-files-after-recomposing.actual/package.xml b/...Projects/mpdWithLabels/__snapshots__/verify-md-files-after-recomposing.actual/package.xml
Benchmark suite	Current: `1a86def`	Previous: `a3542e2`	Ratio
`eda-componentSetCreate-linux`	`182` ms	`183` ms	`0.99`
`eda-sourceToMdapi-linux`	`1998` ms	`2054` ms	`0.97`
`eda-sourceToZip-linux`	`1441` ms	`1498` ms	`0.96`
`eda-mdapiToSource-linux`	`2868` ms	`2913` ms	`0.98`
`lotsOfClasses-componentSetCreate-linux`	`416` ms	`372` ms	`1.12`
`lotsOfClasses-sourceToMdapi-linux`	`3765` ms	`3989` ms	`0.94`
`lotsOfClasses-sourceToZip-linux`	`3161` ms	`3232` ms	`0.98`
`lotsOfClasses-mdapiToSource-linux`	`3531` ms	`3660` ms	`0.96`
`lotsOfClassesOneDir-componentSetCreate-linux`	`626` ms	`650` ms	`0.96`
`lotsOfClassesOneDir-sourceToMdapi-linux`	`6689` ms	`6868` ms	`0.97`
`lotsOfClassesOneDir-sourceToZip-linux`	`5942` ms	`5998` ms	`0.99`
`lotsOfClassesOneDir-mdapiToSource-linux`	`6590` ms	`6576` ms	`1.00`
Benchmark suite	Current: `1a86def`	Previous: `a3542e2`	Ratio
`eda-componentSetCreate-win32`	`390` ms	`429` ms	`0.91`
`eda-sourceToMdapi-win32`	`3404` ms	`3692` ms	`0.92`
`eda-sourceToZip-win32`	`2095` ms	`2164` ms	`0.97`
`eda-mdapiToSource-win32`	`5581` ms	`5465` ms	`1.02`
`lotsOfClasses-componentSetCreate-win32`	`819` ms	`853` ms	`0.96`
`lotsOfClasses-sourceToMdapi-win32`	`7412` ms	`7396` ms	`1.00`
`lotsOfClasses-sourceToZip-win32`	`4704` ms	`4800` ms	`0.98`
`lotsOfClasses-mdapiToSource-win32`	`7517` ms	`7479` ms	`1.01`
`lotsOfClassesOneDir-componentSetCreate-win32`	`1494` ms	`1505` ms	`0.99`
`lotsOfClassesOneDir-sourceToMdapi-win32`	`13565` ms	`13420` ms	`1.01`
`lotsOfClassesOneDir-sourceToZip-win32`	`8599` ms	`8692` ms	`0.99`
`lotsOfClassesOneDir-mdapiToSource-win32`	`13641` ms	`13476` ms	`1.01`