Skip to content

Commit

Permalink
fix: resolver respects forceignore
Browse files Browse the repository at this point in the history
  • Loading branch information
@cristiand391
cristiand391 committed Nov 1, 2024
1 parent 924ebc9 commit 0d94198
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/collections/componentSetBuilder.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export class ComponentSetBuilder {
if (resolvedComponents.forceIgnoredPaths) {
// if useFsForceIgnore = true, then we won't be able to resolve a forceignored path,
// which we need to do to get the ignored source component
const resolver = new MetadataResolver(registry, undefined, false);
const resolver = new MetadataResolver(registry, undefined, true);

for (const ignoredPath of resolvedComponents.forceIgnoredPaths ?? []) {
resolver.getComponentsFromPath(ignoredPath).map((ignored) => {
Expand Down

2 comments on commit 0d94198

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0d94198 Previous: df885d8 Ratio
eda-componentSetCreate-linux 263 ms 227 ms 1.16
eda-sourceToMdapi-linux 2315 ms 2321 ms 1.00
eda-sourceToZip-linux 1863 ms 1836 ms 1.01
eda-mdapiToSource-linux 3620 ms 3501 ms 1.03
lotsOfClasses-componentSetCreate-linux 435 ms 439 ms 0.99
lotsOfClasses-sourceToMdapi-linux 3741 ms 3688 ms 1.01
lotsOfClasses-sourceToZip-linux 3140 ms 3038 ms 1.03
lotsOfClasses-mdapiToSource-linux 3573 ms 3511 ms 1.02
lotsOfClassesOneDir-componentSetCreate-linux 747 ms 748 ms 1.00
lotsOfClassesOneDir-sourceToMdapi-linux 6463 ms 6388 ms 1.01
lotsOfClassesOneDir-sourceToZip-linux 5700 ms 5513 ms 1.03
lotsOfClassesOneDir-mdapiToSource-linux 6405 ms 6355 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0d94198 Previous: df885d8 Ratio
eda-componentSetCreate-win32 619 ms 682 ms 0.91
eda-sourceToMdapi-win32 4177 ms 4709 ms 0.89
eda-sourceToZip-win32 2946 ms 3187 ms 0.92
eda-mdapiToSource-win32 5731 ms 6202 ms 0.92
lotsOfClasses-componentSetCreate-win32 1225 ms 1324 ms 0.93
lotsOfClasses-sourceToMdapi-win32 7751 ms 8366 ms 0.93
lotsOfClasses-sourceToZip-win32 5065 ms 5338 ms 0.95
lotsOfClasses-mdapiToSource-win32 7782 ms 8603 ms 0.90
lotsOfClassesOneDir-componentSetCreate-win32 2087 ms 2313 ms 0.90
lotsOfClassesOneDir-sourceToMdapi-win32 13928 ms 14960 ms 0.93
lotsOfClassesOneDir-sourceToZip-win32 9570 ms 9575 ms 1.00
lotsOfClassesOneDir-mdapiToSource-win32 14259 ms 14061 ms 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.