Jhork/where custom select #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnyhork
requested review from
dehru,
jgellin-sf,
mysticflute and
praksb
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #161 +/- ##
===========================================
- Coverage 94.69% 94.43% -0.26%
===========================================
Files 64 64
Lines 2505 2517 +12
Branches 636 645 +9
===========================================
+ Hits 2372 2377 +5
- Misses 131 138 +7
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dehru
reviewed
Feb 3, 2021
| if (isMultiInput) { | ||
| const rawValues = splitMultiInputValues(normalizedInput); | ||
| const values = rawValues.map(value => { | ||
| const values = rawValues.map((value) => { |
Contributor
There was a problem hiding this comment.
I'm still wondering why your PR has added parens around these single argument values.
Contributor
Author
There was a problem hiding this comment.
yeah we need to compare prettier/linter rules
dehru
reviewed
Feb 3, 2021
| || operatorValue === 'NOT_IN' | ||
| || operatorValue === 'INCLUDES' | ||
| || operatorValue === 'EXCLUDES'); | ||
| return ( |
Contributor
There was a problem hiding this comment.
linter / prettier differences? Not the end of the world but seems like we keep having these type of diffs.
dehru
approved these changes
Feb 3, 2021
dehru
added a commit
that referenced
this pull request
Feb 5, 2021
* Jhork: Support for Simple WHERE Expressions (#101) * move rule to css common (#108) * Preventing webview re-rendering when soql statement has not changed (#105) * Revert "Disable WHERE in model (#113)" * Type-aware where (#109) * Fix preview not updating when autosave is off - issue 120 (#125) * Recognize recoverable where errors (#116) * Operator and Criteria Error Tooltips (#122) * Support IN, NOT IN, INCLUDES, EXCLUDE operators (#123) * Add smarter completin on GROUP BY clause and WHERE literals (#126) * Feature/custom select (#148) * Jhork/custom select fields (#111) * Jhork/custom select from (#130) * Jhork/custom select order by (#134) * set the error overlay to be on top of all other form elements (#150) * prepare to publish 0 .0.30 (#151) * Feature/where (#154) * Jhork: Support for Simple WHERE Expressions (#101) * move rule to css common (#108) * Preventing webview re-rendering when soql statement has not changed (#105) * Revert "Disable WHERE in model (#113)" * Type-aware where (#109) * Recognize recoverable where errors (#116) * Operator and Criteria Error Tooltips (#122) * Support IN, NOT IN, INCLUDES, EXCLUDE operators (#123) * Revert "Feature/where (#154)" (#157) * Add support for line comments ( `//` ) at the top of SOQL files (#132) * Jhork/where custom select (#161) * Fix: 'undefined' in SOQL string (#162) * Clear tooltip when object changes, fix empty soql statement error blocker (#165) * Track to force render on condition change - fix rebase conflict (#166) * do not send event when user still adding input' (#169) * Jhork/clear modifier field bug fix (#168) * handle a option selection event (#178) * cler tooltip error when X is clicked (#180) * Jhork/workflow updates (#163) * Bump versions for release (#181) Co-authored-by: Jonny Hork <jhork@salesforce.com> Co-authored-by: dehru <599418+dehru@users.noreply.github.com> Co-authored-by: Dehru Cromer <dehru.cromer@salesforce.com> Co-authored-by: Fernando Dobladez <fernandodobladez@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Use Custom Select in the where component
What issues does this PR fix or reference?
@W-8616121@