Merge Custom Select Components into Main #152
Conversation
* add soql-statement to model * verify that we include the soql statement in the model * update the package version so we can publish and consume
* Initial support for Aggregate functions. Also: * Fix: Propose "COUNT()" only if right after "SELECT" * Remove special-case for "SELECT (SELECT ), | FROM Foo". Not worth it * Add completion inside function expression Example: SELECT AVG(|) FROM Also: * Improve ANTLR error recovery to better extract FROM expresssions * Make completions inside function expression type-aware * Add smarter completion on GROUP BY clause Also: * Complete only with "groupable" fields. * Give priority to complete GROUP BY with fields which appear on SELECT and are not aggregated or groupped. * On ORDER BY: Complete only with "sortable" fields * Add completion on semi-join SELECTs (in WHERE clauses) * Fix defect when cursor is around multiple newlines * Improve query analysis impl * Pre-select "WHERE" option if provided * Improve support for queries with semi-joins * Refactor: move soql operator semantics to LSP server-side * Add more code-completion proposals for literal values Including: * Range date literals (LAST_YEAR, YESTERDAY, LAST_N_DAYS:n, etc.) * Simple templates for: int, double, string, currency * Quiet completion on HAVING clause * Add a space before opening parenthesis after INCLUDES/EXCLUDES
* set the error overlay to be on top of all other form elements * add z-index to .unsupported-syntax
dehru
requested review from
amphro,
code0100fun,
jgellin-sf,
jonnyhork,
mysticflute,
praksb and
tmock12
as code owners
Codecov Report
@@ Coverage Diff @@
## main #152 +/- ##
==========================================
+ Coverage 88.25% 88.55% +0.29%
==========================================
Files 47 48 +1
Lines 1575 1773 +198
Branches 366 418 +52
==========================================
+ Hits 1390 1570 +180
- Misses 183 201 +18
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dehru
changed the title
| --soql-media-max-width: 480px; | ||
| --soql-label-width: 80px; | ||
| --soql-input-width: 400px; | ||
| --soql-label-container-width: 80px; | ||
| --soql-selection-container-width: 400px; |
There was a problem hiding this comment.
These properties are never used in the data view. I assume they are changed here for consistency with SOQL builder. But should they be removed instead?
There was a problem hiding this comment.
You are correct, they are not used (yet?). I put them there sort of as documentation so we stay in sync with the builder if we do use them. Kind of like the unmodeledsyntax. I could go either way with these, it not that hard to add them back, I just didn't want anyone to forget we have global variables on the builder side.
There was a problem hiding this comment.
I am guessing there is a good chance I will be the one to do any work on the data view anyway, so we can remove them now if we feel that's better.
There was a problem hiding this comment.
Let's leave them for now.
4 participants
What does this PR do?
Updates main with the latest from develop branch
What issues does this PR fix or reference?
Continued LSP improvements
Custom Select Component in Soql Builder UI