Skip to content

Commit

Permalink
refactor: pr feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
@mshanemc
mshanemc committed Jun 14, 2024
1 parent 1eb1fed commit 6c7f7f5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/org/scratchOrgCreate.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ const setExitCodeIfError =
try {
return await p;
} catch (e) {
const sfError = e instanceof SfError ? e : SfError.wrap(e);
const sfError = SfError.wrap(e);
sfError.exitCode = exitCode;
throw sfError;
}
Expand Down

2 comments on commit 6c7f7f5

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 6c7f7f5 Previous: 1eb1fed Ratio
Child logger creation 454710 ops/sec (±2.07%) 481131 ops/sec (±1.59%) 1.06
Logging a string on root logger 794718 ops/sec (±6.50%) 880180 ops/sec (±8.04%) 1.11
Logging an object on root logger 580886 ops/sec (±7.23%) 610459 ops/sec (±7.07%) 1.05
Logging an object with a message on root logger 8493 ops/sec (±203.68%) 1955 ops/sec (±275.75%) 0.23
Logging an object with a redacted prop on root logger 402892 ops/sec (±15.86%) 414398 ops/sec (±15.04%) 1.03
Logging a nested 3-level object on root logger 365370 ops/sec (±7.33%) 349268 ops/sec (±9.74%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 6c7f7f5 Previous: 1eb1fed Ratio
Child logger creation 327550 ops/sec (±0.70%) 325099 ops/sec (±1.04%) 0.99
Logging a string on root logger 738739 ops/sec (±5.82%) 787316 ops/sec (±5.52%) 1.07
Logging an object on root logger 579951 ops/sec (±5.64%) 573495 ops/sec (±6.61%) 0.99
Logging an object with a message on root logger 8942 ops/sec (±190.82%) 6088 ops/sec (±203.62%) 0.68
Logging an object with a redacted prop on root logger 389863 ops/sec (±12.21%) 447290 ops/sec (±10.80%) 1.15
Logging a nested 3-level object on root logger 299001 ops/sec (±6.86%) 337392 ops/sec (±5.02%) 1.13

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.