ci: update node version for perf workflow

forcedotcom · Oct 2, 2024 · 3c52aba · 3c52aba · svc-cli-bot · Oct 2, 2024
1 parent cb60de0
commit 3c52aba
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/.github/workflows/perf.yml b/.github/workflows/perf.yml
@@ -19,6 +19,8 @@ jobs:
     steps:
       - uses: actions/checkout@v4
       - uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
       - uses: salesforcecli/github-workflows/.github/actions/yarnInstallWithRetries@main
         with:
           ignore-scripts: true

diff --git a/scripts/build.js b/scripts/build.js
@@ -45,7 +45,7 @@ const sharedConfig = {
   const filePath = `${tmpOutputFolder}/index.js`;
   let bundledEntryPoint = fs.readFileSync(filePath, 'utf8');
 
-  // There is a wrong reference after bundling due to a bug from esbuild. We will replace it with the correct one.
+  // There is a wrong reference after bundling due to a bug from esbuild-plugin-pino. We will replace it with the correct one.
   const searchString = /\$\{process\.cwd\(\)\}\$\{require\("path"\)\.sep\}tmp-lib/g;
   const replacementString = `\${__dirname}\${require("path").sep}`;
Benchmark suite	Current: `3c52aba`	Previous: `2bb5d54`	Ratio
`Child logger creation`	`497813` ops/sec (`±0.87%`)	`468709` ops/sec (`±1.24%`)	`0.94`
`Logging a string on root logger`	`971308` ops/sec (`±10.32%`)	`810730` ops/sec (`±10.67%`)	`0.83`
`Logging an object on root logger`	`38228` ops/sec (`±185.56%`)	`651300` ops/sec (`±5.29%`)	`17.04`
`Logging an object with a message on root logger`	`449567` ops/sec (`±5.24%`)	`2842` ops/sec (`±243.03%`)	`0.0063216383764822595`
`Logging an object with a redacted prop on root logger`	`517187` ops/sec (`±6.52%`)	`456313` ops/sec (`±10.56%`)	`0.88`
`Logging a nested 3-level object on root logger`	`20665` ops/sec (`±185.77%`)	`373675` ops/sec (`±7.35%`)	`18.08`
Benchmark suite	Current: `3c52aba`	Previous: `2bb5d54`	Ratio
`Child logger creation`	`344563` ops/sec (`±0.36%`)	`347857` ops/sec (`±0.36%`)	`1.01`
`Logging a string on root logger`	`812221` ops/sec (`±7.44%`)	`850885` ops/sec (`±5.64%`)	`1.05`
`Logging an object on root logger`	`617253` ops/sec (`±9.98%`)	`656759` ops/sec (`±5.06%`)	`1.06`
`Logging an object with a message on root logger`	`4978` ops/sec (`±209.97%`)	`18673` ops/sec (`±185.98%`)	`3.75`
`Logging an object with a redacted prop on root logger`	`424101` ops/sec (`±15.18%`)	`536612` ops/sec (`±5.31%`)	`1.27`
`Logging a nested 3-level object on root logger`	`309547` ops/sec (`±5.74%`)	`19396` ops/sec (`±184.97%`)	`0.06265930537204366`