Skip to content

Commit

Permalink
chore: limit 68 to deploy error
Browse files Browse the repository at this point in the history
  • Loading branch information
mshanemc committed Jun 14, 2024
1 parent 74f9e1b commit 2254fae
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
3 changes: 0 additions & 3 deletions src/org/scratchOrgCreate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,6 @@ export const scratchOrgCreate = async (options: ScratchOrgCreateOptions): Promis
});

// anything after this point (org is created and auth'd) is potentially recoverable with the resume scratch command.
process.exitCode = 68;

await scratchOrgAuthInfo.handleAliasAndDefaultSettings({
...{
alias,
Expand Down Expand Up @@ -322,7 +320,6 @@ export const scratchOrgCreate = async (options: ScratchOrgCreateOptions): Promis
cache.unset(scratchOrgInfoId);
const authFields = authInfo.getFields();
await Promise.all([emit({ stage: 'done', scratchOrgInfo: soi }), cache.write(), emitPostOrgCreate(authFields)]);
process.exitCode = 0;
return {
username,
scratchOrgInfo: soi,
Expand Down
12 changes: 6 additions & 6 deletions src/org/scratchOrgSettingsGenerator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -329,12 +329,12 @@ export default class SettingsGenerator {
const failures = (Array.isArray(componentFailures) ? componentFailures : [componentFailures])
.map((failure) => `[${failure.problemType}] ${failure.fullName} : ${failure.problem} `)
.join('\n');
const error = new SfError(
`A scratch org was created with username ${username}, but the settings failed to deploy due to: \n${failures}`,
'ProblemDeployingSettings'
);
error.setData(result);
throw error;
throw SfError.create({
message: `A scratch org was created with username ${username}, but the settings failed to deploy due to: \n${failures}`,
name: 'ProblemDeployingSettings',
data: { ...result, username },
exitCode: 68,
});
}
}

Expand Down

3 comments on commit 2254fae

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - ubuntu-latest

Benchmark suite Current: 2254fae Previous: 74f9e1b Ratio
Child logger creation 465358 ops/sec (±1.74%) 457457 ops/sec (±1.99%) 0.98
Logging a string on root logger 806121 ops/sec (±7.20%) 771872 ops/sec (±10.67%) 0.96
Logging an object on root logger 599039 ops/sec (±5.97%) 572567 ops/sec (±10.13%) 0.96
Logging an object with a message on root logger 3841 ops/sec (±224.27%) 7566 ops/sec (±205.24%) 1.97
Logging an object with a redacted prop on root logger 518366 ops/sec (±6.12%) 494612 ops/sec (±6.77%) 0.95
Logging a nested 3-level object on root logger 394311 ops/sec (±7.39%) 372959 ops/sec (±6.80%) 0.95

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logger Benchmarks - windows-latest

Benchmark suite Current: 2254fae Previous: 74f9e1b Ratio
Child logger creation 328782 ops/sec (±1.56%) 319989 ops/sec (±0.95%) 0.97
Logging a string on root logger 849359 ops/sec (±8.05%) 714523 ops/sec (±7.13%) 0.84
Logging an object on root logger 632056 ops/sec (±10.71%) 608048 ops/sec (±5.20%) 0.96
Logging an object with a message on root logger 19203 ops/sec (±186.28%) 6743 ops/sec (±203.34%) 0.35
Logging an object with a redacted prop on root logger 518929 ops/sec (±7.35%) 482009 ops/sec (±6.18%) 0.93
Logging a nested 3-level object on root logger 18223 ops/sec (±185.33%) 347842 ops/sec (±5.09%) 19.09

This comment was automatically generated by workflow using github-action-benchmark.

@svc-cli-bot
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Logger Benchmarks - windows-latest'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.

Benchmark suite Current: 2254fae Previous: 74f9e1b Ratio
Logging a nested 3-level object on root logger 18223 ops/sec (±185.33%) 347842 ops/sec (±5.09%) 19.09

This comment was automatically generated by workflow using github-action-benchmark.

Please sign in to comment.