FIX(pmd): @W-18808343@: Prevent AppExchange rules from running in an infinite loop #312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -25,17 +25,11 @@ public class DangerousChangeProtectionMethods extends AbstractApexRule { | |||
|
|
|||
| @Override | |||
| public Object visit(ASTMethodCallExpression node, Object data) { | |||
| if (Helper.isTestMethodOrClass(node)) { | |||
| super.visit(node, data); | |||
There was a problem hiding this comment.
The issue was because we super.visit was called twice (once here and once below). Ravindra should have returned the super.visit output here instead of continuing.
It caused an issue with this one file because this one file has a name that is referenced within itself. Since super was called twice it wasn't able to use its recursion detection I believe.
stephen-carter-at-sf
force-pushed
the
sc/W-18808343
branch
from
f882673 to
ebe6abd
Compare
jfeingold35
approved these changes
Jun 20, 2025
jfeingold35
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes forcedotcom/code-analyzer#1811