@W-18250548 add deprecation marker for signpost removal in upcoming release of 14.0 #3882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## dev #3882 +/- ##
==========================================
+ Coverage 62.48% 62.50% +0.01%
==========================================
Files 247 247
Lines 22311 22311
==========================================
+ Hits 13942 13945 +3
+ Misses 8369 8366 -3
π New features to boost your workflow:
|
bbirman
reviewed
Jun 26, 2025
| @@ -30,6 +30,8 @@ | |||
| NS_ASSUME_NONNULL_BEGIN | |||
|
|
|||
| NS_SWIFT_NAME(SalesforceInstrumentationHelper) | |||
| /// @deprecated Signpost logging is deprecated and this helper will be removed in version 14.0. | |||
| __attribute__((deprecated("Signpost logging is deprecated and will be removed in version 14.0"))); | |||
There was a problem hiding this comment.
Is it possible to use the SFSDK_DEPRECATED macro instead?
bbirman
approved these changes
Jun 26, 2025
wmathurin
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π§ Deprecate SFSDKInstrumentationHelper Ahead of Removal in v14.0
This PR marks SFSDKInstrumentationHelper as deprecated in preparation for its removal in version 14.0.
π Context
β’ The class was originally introduced to support internal signpost-based debugging/logging.
β’ There is no known customer usage of this functionality.
β’ Weβre moving to remove unnecessary internal tooling from the SDK surface.
𧱠Changes
β’ Added attribute((deprecated)) to the SFSDKInstrumentationHelper interface.
β’ Included an Xcode-friendly doc comment (@deprecated) for visibility in IDEs.
β Why This Matters
β’ Prevents client teams from relying on an internal-only utility.
β’ Provides a clear warning and migration window before permanent removal.
β’ Keeps the public API lean and maintainable.
π« No Breaking Changes
β’ This class was not meant for external use.
β’ Client apps not referencing SFSDKInstrumentationHelper will see no impact.