Skip to content

Cloner class #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

smolchanovsky
Copy link

@smolchanovsky smolchanovsky commented Oct 20, 2018

This class will allow users not to write wrappers to make their code more testable and flexible.

@niemyjski
Copy link

Looks good, but it would be really nice to get rid of the statics..

@force-net
Copy link
Owner

Sorry for long delay. What is the sense of this PR? It looks like as copy of DeepClonerExtensions class but without static members (except ShallowClone but it seems as mistake in PR). If this class is helper for testing or for ability to replace implementation, all methods should be virtual (to override it in descendant class). Or some ICloner interface should be extracted.

@smolchanovsky
Copy link
Author

This class is really helper for testing and replacing implementations. But you are absolutely right, without an interface it makes no sense. For some reason, I forgot to add it, sorry.

@smolchanovsky
Copy link
Author

@force-net hi!
4 years have passed, I think it's time to merge pr, if everything is ok =)

@force-net
Copy link
Owner

Sorry for delay. I'll try to find time to do this on new year's holidays.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants