Skip to content

Conversation

@jiayuehua
Copy link
Contributor

No description provided.

@jiayuehua
Copy link
Contributor Author

microsoft/vcpkg#31905

@jiayuehua
Copy link
Contributor Author

@foonathan

@foonathan
Copy link
Owner

Can you elaborate on the consequences and reason for this change?

@jiayuehua
Copy link
Contributor Author

jiayuehua commented Jun 15, 2023

If installed to include/foonathan, then client code must use
include "foonathan/foonathan/memory…" other than include "foonathan/memory".

after this fix, some other vcpkg port that already rely on your memory lib can work again.

also from microsoft/vcpkg#30212

CMake Error in src/cpp/CMakeLists.txt:
  Imported target "foonathan_memory" includes non-existent path

    "D:/installed/x86-windows/include/foonathan_memory"

  in its INTERFACE_INCLUDE_DIRECTORIES.

@foonathan foonathan merged commit f7afdd1 into foonathan:main Jun 18, 2023
@foonathan
Copy link
Owner

Okay, that's fair. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants