WIP: Bugfix: fix issue 145 compile on VS 2022 #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Ignore the MacOS failures; I'll fix. |
foonathan
force-pushed
the
bugfix/fix-issue-145-compile-on-msvc-2022
branch
from
852c244 to
10452d3
Compare
…m:burnpanck/memory into bugfix/fix-issue-145-compile-on-msvc-2022
burnpanck
force-pushed
the
bugfix/fix-issue-145-compile-on-msvc-2022
branch
from
434dc58 to
9d2b80e
Compare
foonathan
requested changes
Nov 27, 2022
foonathan
approved these changes
Nov 28, 2022
Owner
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides a workaround around a compiler bug, which seems to have appeared in VS 2022. It appears that the bug is only triggered with
/permissive-, which is enabled by default when using/std:c++20. As I was unable to make CMAKE set the former, I simply set the latter in the accompanying CI tests.In this version of the PR, the workaround is hidden behind a
FOONATHAN_SFINAE_WORKAROUNDguard, which for now is implemented unconditionally, as I haven't fully determined what versions and compiler flag combinations really trigger the issue. Since you have usedstd::declvalin other places withinFOONATHAN_SFINAE, maybe the workaround could actually be used unconditionally everywhere, and the guard removed? Let me know.