fix(opentype/STAT/ital_axis): skip static fonts #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…c' static and variable fonts correctly
ollimeier
force-pushed
the
issue-521-stat-ital_axis
branch
from
8e268bd to
bdeebb2
Compare
* add check for stroke and classifications in metadata.pb * rustfmt * remove valid_stroke_and_classifications.rs * add the check in validate.rs * removed mod valid_stroke_and_classifications; in mod.rs * rustfmt * update link (PR URL) * chore(metadata/validate): Merge into existing validate check --------- Co-authored-by: Simon Cozens <simon@simon-cozens.org>
* refactor(required_name_ids): move from fontwerk to universal Co-Authored-By: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix: universal/required_name_ids config --------- Co-authored-by: Olli Meier <olli.meier@productiontype.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relates to issue #521
The check 'opentype/STAT/ital_axis' is intended for variable fonts, but it does not skip static fonts. This PR fixes the issue.
I added the Noto Sans font family, even though I only use two styles I added the whole Noto Sans font family. It's worth having the entire font family.
Checklist
CHANGELOG.md