rename: 'family/control_chars' => 'control_chars'

CHANGELOG.md

@@ -6,6 +6,10 @@ A more detailed list of changes is available in the corresponding milestones for
 ### Noteworthy code-changes
   - Full fix for bug where check details with more severe status would be missing from the HTML report if a check with the same ID but less severe status was omitted (issue #4687)
 
+### Changes to existing checks
+### On the Universal profile
+  - **[family/control_chars]:** renamed to **control_chars** as it is not realy a family-wide check. (issue #4896)
+
 
 ## 0.13.0a5 (2024-Nov-10)
   - **Users are encouraged to try this pre-release as we're approaching the date when we'll cut a final v0.13.0 release...**

Lib/fontbakery/checks/glyphset.py

@@ -90,7 +90,7 @@ def check_case_mapping(ttFont):
 
 
 @check(
-    id="family/control_chars",
+    id="control_chars",
     conditions=["are_ttf"],
     rationale="""
         Use of some unacceptable control characters in the U+0000 - U+001F range can

Lib/fontbakery/profiles/adobefonts.py

@@ -51,9 +51,9 @@
         "color_cpal_brightness",
         "colorfont_tables",
         "contour_count",  # was temporarily removed
+        "control_chars",
         "epar",
         "empty_glyph_on_gid1_for_colrv0",
-        "family/control_chars",
         "file_size",
         "fontdata_namecheck",
         "glyf_nested_components",

Lib/fontbakery/profiles/fontbureau.py

@@ -8,10 +8,10 @@
         "cmap/format_12",
         "color_cpal_brightness",
         "colorfont_tables",
+        "control_chars",
         "empty_glyph_on_gid1_for_colrv0",
         "empty_letters",
         "epar",
-        "family/control_chars",
         "file_size",
         "fvar_name_entries",
         "fontdata_namecheck",

Lib/fontbakery/profiles/microsoft.py

@@ -15,6 +15,7 @@
         "cmap/format_12",
         "color_cpal_brightness",
         "colorfont_tables",
+        "control_chars",
         "designspace_has_consistent_codepoints",
         "designspace_has_consistent_glyphset",
         "designspace_has_consistent_groups",
@@ -23,7 +24,6 @@
         "empty_glyph_on_gid1_for_colrv0",
         "empty_letters",
         "epar",
-        "family/control_chars",
         "file_size",
         "fvar_name_entries",
         "fontdata_namecheck",

Lib/fontbakery/profiles/universal.py

@@ -32,10 +32,10 @@
             "color_cpal_brightness",
             "colorfont_tables",
             "contour_count",
+            "control_chars",
             "empty_glyph_on_gid1_for_colrv0",
             "empty_letters",
             "epar",
-            "family/control_chars",
             "family/single_directory",
             "family/vertical_metrics",
             "family/win_ascent_and_descent",

tests/test_checks_glyphset.py

@@ -31,7 +31,7 @@ def test_check_render_own_name(check):
     assert_results_contain(check(ttFont), FAIL, "render-own-name")
 
 
-@check_id("family/control_chars")
+@check_id("control_chars")
 def test_check_family_control_chars(check):
     """Are any unacceptable control characters present in font files?"""