Use gflanguages module to check sample rendering
#3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipesanches
force-pushed
the
issue_3605
branch
from
5e830ac
to
cfc200a
Compare
|
It seems that there's a licensing issue here, as Before merging this PR, I'll try to address this problem (maybe releasing a |
|
yes, I've just confirmed that the hyperglot python module is licensed "GNU General Public License v3 (GNU GPLv3)" I'll remove the method and dependency and release gflanguages v0.2.0 I can keep the method as a separate sample snippet with a comment regarding its licensing implications. |
felipesanches
added a commit
to googlefonts/lang
that referenced
this pull request
Feb 18, 2022
- Removed SupportedLanguages method as it relies on hyperglot, which is under the GPLv3, to keep gftranslate under Apache 2.0 - The method is still available as a separate code-snippet (not part of gflanguages itself), and any program using that snippet will need to comply with the GPLv3. - For more details, see: fonttools/fontbakery#3617 (comment)
felipesanches
added a commit
to googlefonts/lang
that referenced
this pull request
Feb 18, 2022
- Removed SupportedLanguages method as it relies on hyperglot, which is under the GPLv3, to keep gftranslate under Apache 2.0 - The method is still available as a separate code-snippet (not part of gflanguages itself), and any program using that snippet will need to comply with the GPLv3. - For more details, see: fonttools/fontbakery#3617 (comment)
felipesanches
added a commit
to googlefonts/lang
that referenced
this pull request
Feb 18, 2022
- Removed SupportedLanguages method as it relies on hyperglot, which is under the GPLv3, to keep gftranslate under Apache 2.0 - The method is still available as a separate code-snippet (not part of gflanguages itself), and any program using that snippet will need to comply with the GPLv3. - For more details, see: fonttools/fontbakery#3617 (comment)
felipesanches
added a commit
to googlefonts/lang
that referenced
this pull request
Feb 18, 2022
- Removed SupportedLanguages method as it relies on hyperglot, which is under the GPLv3, to keep gftranslate under Apache 2.0 - The method is still available as a separate code-snippet (not part of gflanguages itself), and any program using that snippet will need to comply with the GPLv3. - For more details, see: fonttools/fontbakery#3617 (comment)
felipesanches
added a commit
to googlefonts/lang
that referenced
this pull request
Feb 18, 2022
- Removed SupportedLanguages method as it relies on hyperglot, which is under the GPLv3, to keep gftranslate under Apache 2.0 - The method is still available as a separate code-snippet (not part of gflanguages itself), and any program using that snippet will need to comply with the GPLv3. - For more details, see: fonttools/fontbakery#3617 (comment)
com.google.fonts/check/metadata/can_render_samples Check that the fonts can render the sample texts for all languages specified on METADATA.pb, by using the new `gflanguages` module. (issue fonttools#3605)
felipesanches
force-pushed
the
issue_3605
branch
from
cfc200a
to
3294838
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
com.google.fonts/check/metadata/can_render_samples
Check that the fonts can render the sample texts for all languages specified on METADATA.pb, by using the new
gflanguagesmodule.(issue #3605)