-
Notifications
You must be signed in to change notification settings - Fork 5
Add steps to create and release Linux binary #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use pre-commit to avoid linter errors.
I think you just need to do pre-commit install in the repo dir.
|
Please rebase to main: I update the macos and Windows builds to use Python 3.13. There should be no conflict. |
|
Thank you! I will do a test release. |
|
After I get the release working, I will update the website. This binary is only for x86, right? Would this be a good label on the website? Or should it say |
|
Or should this not be mentioned, and rather link to the flatpak version once that's up and running? |
|
It can already be used directly in Ubuntu(x86_64) , so Fontra Pak for Ubuntu x86_64 can be mentioned. We have to set some other workflow in the fontra-flatpak repository that will query the release in fontra-pak and update the manifest and metainfo file accordingly whenevere the relase is changed. It can be done as cron or workflow dispatch or alternatively it can be done by trigger from the the fontra-pak repository. Which way you think is better ? |
|
fontra-pak can trigger an event in a different repo on release. I already do that for the website: Sender: fontra-pak/.github/workflows/python-app.yml Lines 251 to 256 in 64f3a3c
Receiver: This would be relatively easy to add. The first step would be to get it working with a manual trigger, then once everything is good to go I can add the release event trigger. In the meantime, should I add a direct download to the Ubuntu x86_64 download on the website, or shall I wait until the flatpak version works so we can link to that? Or should ultimately both be linked to? |
|
Link to Ubuntu x86_64 binary can be added to website. When Flatpak is completed we can replace that with Flatpak and Snap links. Already about 70 people use the unofficial snap , so that can also be made official with minimum effort |
This pull request will generate and release Linux binary along with MacOS and Windows one. This binary will be used to create both snap and flatpak