Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logo and update for latest Pluto #5

Closed
wants to merge 1 commit into from
Closed

Conversation

barche
Copy link

@barche barche commented Sep 27, 2020

This adds the logo and updates the run command for compatibility with the latest Pluto.jl. The logo makes things look a lot nicer in jupyterlab. I am not a Python expert, so there may be a less contorted way of doing this.

@fonsp
Copy link
Owner

fonsp commented Sep 27, 2020

Thanks! Can you rewrite it to maintain the single-file-package structure? I want this repo to be as slim as possible. Having no folders also means that you can write it in a github gist

@fonsp
Copy link
Owner

fonsp commented Sep 27, 2020

Oh and can you describe how you installed this as a jupyter lab extension? Should we register this package with pip? Any other suggestions? fonsp/PlutoUtils.jl#4

@barche
Copy link
Author

barche commented Sep 27, 2020

Thanks! Can you rewrite it to maintain the single-file-package structure? I want this repo to be as slim as possible

Unfortunately I don't know how, I went for the package structure to have a reliable place to put the icon (the logo from Pluto.jl). An alternative might be to refer to the Pluto.jl dir, but that would require starting Julia in setup_plutoserver to get the path, which may change when the user updates Pluto.jl.

Oh and can you describe how you installed this as a jupyter lab extension?

All I needed to do is install the jupyterlab extension for the server proxy, then the package works as-is, adding a button in the jupyterlab launcher:

jupyter labextension install @jupyterlab/server-proxy

Should we register this package with pip?

That would be nice, yes. I want to use this in our custom jupyterlab single-user Docker image, having it in pip would make that simpler.

@fonsp fonsp closed this Jan 6, 2021
@fonsp
Copy link
Owner

fonsp commented Jan 6, 2021

Hey @barche !

I closed this PR because this repository (fonsp/pluto-on-binder) is really for only one purpose: a repository that binder can launch from to run the Pluto demo:

Schermafbeelding 2021-01-06 om 11 25 18

But the other purpose, Pluto as a jupyterlab extension, is something that still needs some work! See the discussion over at fonsp/PlutoUtils.jl#4 and the post by Max Koehler: https://www.maximiliankoehler.de/posts/pluto-server/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants