Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to backtick latex delimiting #953

Merged

Conversation

jeremiahpslewis
Copy link
Contributor

Per the very helpful tip in this discourse thread, it seems like there might be a lot to be gained and little to be lost by encouraging users to use backticks instead of dollar signs for latex snippets, so that dollar signs are reserved for (and more reliably parsed) in the case of $(1+1) style interpolation.

@fonsp
Copy link
Owner

fonsp commented Feb 27, 2021

Thanks! Did you check all sample notebooks?

@jeremiahpslewis
Copy link
Contributor Author

jeremiahpslewis commented Feb 27, 2021

@fonsp, no, just started rechecking, I’m missing some, will fix.

@jeremiahpslewis
Copy link
Contributor Author

@fonsp Can now in good faith say that I've reviewed all of the sample notebooks. Some of the diff updates are because I reran the notebooks in 0.14; let me know if you'd prefer I remove these commits.

@fonsp
Copy link
Owner

fonsp commented Feb 27, 2021

Yeah can you try to get smaller diffs? Try to change the notebook files without running them

@jeremiahpslewis jeremiahpslewis force-pushed the feature/move-to-unambigouous-latex branch from 09a3a2d to 111d6c9 Compare February 27, 2021 09:02
@jeremiahpslewis
Copy link
Contributor Author

@fonsp Ok, think we have a clean diff now. :)

@fonsp fonsp merged commit 7b1041b into fonsp:master Mar 1, 2021
@jeremiahpslewis jeremiahpslewis deleted the feature/move-to-unambigouous-latex branch March 1, 2021 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants