add checks to bind macro #728
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this prevents executing code that could break some functions by defining new methods Example: ```julia @Bind a CheckBox(), default=true ``` Would throw an error before executing where it would not have previously, redefining `CheckBox()` to `true`
|
Thanks! But I would rather fix the underlying issue with ExpressionExplorer: #486 (comment) |
|
About tests: this is difficult because you need to run a browser, but it is being worked on: #621 |
|
For example, this code: @bind x myslider=Slider(1:100)is legal, as is: @bind y myslider::SliderThe bug in our expression explorer meant that the user-generated function |
|
You're right ! I had not fully understood the scope of the problem. Sorry for the time wasted |
|
No worries, always happy with your contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
This prevents executing code that could break some functions by defining new methods.
Example:
Would throw an error before executing where it would not have
previously, redefining
CheckBox()totrue(see #486).There seems to be currently no tests for
@bind(https://github.com/fonsp/Pluto.jl/blob/master/test/runtests.jl#L23).Should I add some ?
Fixes #486