Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔌 Automatic reconnect #370

Merged
merged 12 commits into from
Sep 6, 2020
Merged

🔌 Automatic reconnect #370

merged 12 commits into from
Sep 6, 2020

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Sep 6, 2020

No description provided.

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

@shashi it's working! It doesn't compare states yet when you reconnect - it just reconnects. So it will glitch out for multiple clients

@fonsp fonsp merged commit 4d0bf17 into master Sep 6, 2020
@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

I have updated the binder - try it out:

https://mybinder.org/v2/gh/fonsp/vscode-binder/master?urlpath=pluto

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

Still needs to be faster but i have some ideas

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

holy moly

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

#105

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

#281 #280

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

@lungben Maybe you can help me make the binder faster?

@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

@dralletje

@fonsp fonsp deleted the ws-reconnect branch September 6, 2020 11:20
@fonsp
Copy link
Owner Author

fonsp commented Sep 6, 2020

@shashi
Copy link

shashi commented Sep 7, 2020

So tell me can we put this on the website? :-p

What would be the problems?

So if say 10 people are looking at it, does it start 10 mybinders?

What about latency?

I tried the glitch link, looks awesome! it takes a while but it works!

@fonsp
Copy link
Owner Author

fonsp commented Sep 9, 2020

It's down to 40 seconds now! (So 2x as fast) Try it again
20 seconds until the pluto main menu, 40 seconds until you can read the first notebook text (when opening a direct link)

We had a go with running PackageCompiler, but the binder build step did not like it so we're still not creating a custom sysimage. Ideally for the lectures, you would not only precompile Pluto but also all the dep packages, by running the notebook as a representative workload for PackageCompiler

1000 students will launch 1000 binders. Don't know if that's a problem. I'm guessing that they are used to getting traffic spikes from lectures and presentations.

Latency is a problem if you have poor internet - most UI actions have to make a round trip. But typing is offline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants