-
-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔌 Automatic reconnect #370
Conversation
@shashi it's working! It doesn't compare states yet when you reconnect - it just reconnects. So it will glitch out for multiple clients |
I have updated the binder - try it out: https://mybinder.org/v2/gh/fonsp/vscode-binder/master?urlpath=pluto |
Omg!!! I can get it to link to the file!! Put this in an iframe and we're done! |
Still needs to be faster but i have some ideas |
holy moly |
@lungben Maybe you can help me make the binder faster? |
So tell me can we put this on the website? :-p What would be the problems? So if say 10 people are looking at it, does it start 10 mybinders? What about latency? I tried the glitch link, looks awesome! it takes a while but it works! |
It's down to 40 seconds now! (So 2x as fast) Try it again We had a go with running PackageCompiler, but the binder build step did not like it so we're still not creating a custom sysimage. Ideally for the lectures, you would not only precompile Pluto but also all the dep packages, by running the notebook as a representative workload for PackageCompiler 1000 students will launch 1000 binders. Don't know if that's a problem. I'm guessing that they are used to getting traffic spikes from lectures and presentations. Latency is a problem if you have poor internet - most UI actions have to make a round trip. But typing is offline |
No description provided.