Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up frontend CSS #2987

Merged
merged 7 commits into from
Aug 11, 2024
Merged

Tidy up frontend CSS #2987

merged 7 commits into from
Aug 11, 2024

Conversation

savq
Copy link
Contributor

@savq savq commented Aug 11, 2024

  • Create fonts/ and themes/ directories
  • Organize style tags
    • Use a single set of style tags for julia, python, and javascript.
  • Check mismatches between light/dark themes
    • Some variables are not defined in both files, so I added comments where they're missing.
    • Some variables are probably wrong (copy-pasted were they shouldn't have), but I left them as-is.
    • (Hopefully we can use light-dark() in the near future)
  • Rename codemirror color variables

I made this PR to make it easier to update the syntax highlighting colors later. It doesn't change any colors.

Create `fonts/` directory and move font files.
- Use a single set of style tags for julia, javascript and python
- Rename `pluto_syntax_colors` to `pluto_syntax_colors_julia`
Add comments so there's no line mismatches between the two files.
Some variables are not defined in both files, which made it slightly
annoying to compare them.
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/savq/Pluto.jl", rev="savq/frontend")
julia> using Pluto

@fonsp
Copy link
Owner

fonsp commented Aug 11, 2024

Awesome, thanks!

@fonsp fonsp merged commit 45be7c1 into fonsp:main Aug 11, 2024
6 checks passed
@savq savq changed the title Tidy up frontend Tidy up frontend CSS Aug 11, 2024
@savq savq deleted the savq/frontend branch August 11, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants