Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch any-pointer:coarse to pointer:coarse #2631

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

disberd
Copy link
Contributor

@disberd disberd commented Aug 23, 2023

The current CSS keeps the hide cell buttons always on when Pluto is opened on laptops which also have a touchscreen.

Using pointer instead of any-pointer should only make the button always on only on devices that have the touchscreen as primary.

With the proposed change the button will still be always on on devices whose primary pointer is a touchscreen, even if they have a secondary pointer connected with fine accuracy as the media query for pointer:coarse comes after the one with any-pointer:fine

The current CSS keeps the hide cell buttons always on when Pluto is opened on laptops which also have a touchscreen.

Using pointer instead of any-pointer should only make the button always on only on devices that have the touchscreen as primary.
@github-actions
Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/disberd/Pluto.jl", rev="disberd-patch-1")
julia> using Pluto

@Pangoraw
Copy link
Collaborator

Cool! I think it makes sense, it would be nice if browsers could change the primary pointer to coarse when you use the touchscreen kind of like mouse/controller switch in video games.

@Pangoraw Pangoraw merged commit 83ec7c5 into fonsp:main Aug 24, 2023
3 checks passed
@fonsp fonsp added the frontend Concerning the HTML editor label Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Concerning the HTML editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants