Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging doesn't respect maxlog #1858

Closed
Joel-Dahne opened this issue Jan 27, 2022 · 2 comments · Fixed by #1877 or #1911
Closed

Logging doesn't respect maxlog #1858

Joel-Dahne opened this issue Jan 27, 2022 · 2 comments · Fixed by #1877 or #1911
Labels
display & PlutoRunner & AbstractPlutoDingetjes.jl logging About `@info`, `@warn`, etc

Comments

@Joel-Dahne
Copy link
Contributor

pluto-maxlog.mp4

The new logging feature for Pluto doesn't support the maxlog argument for logging. Here is a link to the notebook.

I can also maybe note that I had performance issues with Pluto when there was a very large number of logs. You can try to increase the counter in the loop to, say, 10000, and at least for me the webpage grinds to a halt. In my case it was only a problem because maxlog was not respected though.
@fonsp
Copy link
Owner

fonsp commented Jan 27, 2022

(This is referring to the "conventional meaning" section of https://docs.julialang.org/en/v1/stdlib/Logging/#Logging.@logmsg )

@roland-KA
Copy link

Same problem here. The default value should be > 1. Even when only a few lines are printed, the output gets unreadable as in the following example:

The message 'Attempting to evaluate 40 models.' covers here one (or several) message beneath.

@fonsp fonsp added the display & PlutoRunner & AbstractPlutoDingetjes.jl label Jan 30, 2022
Pangoraw added a commit that referenced this issue Jan 30, 2022
@Pangoraw
respect maxlog keyword for logs, fixes #1858
309703b
@Pangoraw Pangoraw linked a pull request Jan 30, 2022 that will close this issue
respect maxlog keyword for logs, fixes #1858 #1877
Merged
fonsp added a commit that referenced this issue Feb 2, 2022
@Pangoraw @fonsp
respect maxlog keyword for logs, fixes #1858 (#1877)
d3bc5ec 
Co-authored-by: Fons van der Plas <fonsvdplas@gmail.com>
pankgeorg added a commit that referenced this issue Feb 8, 2022
@pankgeorg
Merge tag 'v0.18.0' into what-if-distrubuted2
3436275 
> Try this release in your browser! _(Available 30 minutes after the release)_
>
> <a href="https://binder.plutojl.org/v0.18.0/"><img alt="Binder logo" src="https://mybinder.org/badge_logo.svg"></a>

**Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!**

[Diff since v0.17.7](v0.17.7...v0.18.0)

**Merged pull requests:**
- Make document currentscript work (#1765) (@dralletje)
- don't count logs messages multiple times for pluto-logs width (#1843) (@Pangoraw)
- Pattern matching system for lezer code (#1849) (@dralletje)
- minor fix: Tables integration caused method ambiguation for Union{}[] (#1851) (@16bitmood)
- Fix #1852, relocatable changes for sysimage usage. (#1853) (@MichaelHatherly)
- Re-enable parseMixed (#1855) (@pankgeorg)
- DOI in REAMDE for citation (#1864) (@rikhuijzer)
- Use pkgdir instead of pathof (#1867) (@rikhuijzer)
- Hide banner in CI (#1868) (@rikhuijzer)
- Server-side events as configuration (#1871) (@ctrekker)
- fix is_stdlib() for nightly and enable nightly tests (#1874) (@Pangoraw)
- Awesome! Line wrapping! (#1876) (@dralletje)
- respect maxlog keyword for logs, fixes #1858 (#1877) (@Pangoraw)
- allow .. as an identifier, fixes #1875 (#1878) (@Pangoraw)
- Server start event (#1882) (@ctrekker)
- Julia 1.6 minimum (#1885) (@fonsp)
- New heuristic to skip intermediate bond values (#1892) (@fonsp)
- Send queued bond changes when last script finishes (#1898) (@fonsp)

**Closed issues:**
- Pkg.jl will corrupt itself on Windows (#671)
- Failure creating JuMP DenseAxisArray (#806)
- Frontend tests fail too often (#1234)
- Open multiple notebooks at start and without browser (#1278)
- Segmentation faults on Julia 1.7 M1 (#1722)
- Table of content overlaps text in static HTML (#1770)
- Pluto hangs when cell contains `(md" ", md"$t")` (#1800)
- Cell drag drop broken in Linux Chrome v97 (#1809)
- Tables integration causes method ambiguities for `pluto_showable` (#1815)
- Segfault with CSV, SQLite, tables (M1) (#1842)
- Use RelocatableFolders.jl instead of project_relative_dir to allow sysimages (#1852)
- Logging doesn't respect `maxlog` (#1858)
- TOC in dark mode is still light when aside (#1860)
- ProgressLogging: suppressed logging in Turing.jl (#1862)
- Cannot update to version 0.17.7 (#1869)
- Stdlib packages marked as not found (#1872)
- EllipsisNotation.jl (`randn((10,10))[1, ..]`) does not work (#1875)
- Too many intermediate bond values (#1891)
pankgeorg added a commit that referenced this issue Feb 8, 2022
@pankgeorg
Merge tag 'v0.18.0' into pluto-events-interface-0.18
8eb5476 
> Try this release in your browser! _(Available 30 minutes after the release)_
>
> <a href="https://binder.plutojl.org/v0.18.0/"><img alt="Binder logo" src="https://mybinder.org/badge_logo.svg"></a>

**Generate your own binder links using [pluto-on-binder.glitch.me](https://pluto-on-binder.glitch.me/)!**

[Diff since v0.17.7](v0.17.7...v0.18.0)

**Merged pull requests:**
- Make document currentscript work (#1765) (@dralletje)
- don't count logs messages multiple times for pluto-logs width (#1843) (@Pangoraw)
- Pattern matching system for lezer code (#1849) (@dralletje)
- minor fix: Tables integration caused method ambiguation for Union{}[] (#1851) (@16bitmood)
- Fix #1852, relocatable changes for sysimage usage. (#1853) (@MichaelHatherly)
- Re-enable parseMixed (#1855) (@pankgeorg)
- DOI in REAMDE for citation (#1864) (@rikhuijzer)
- Use pkgdir instead of pathof (#1867) (@rikhuijzer)
- Hide banner in CI (#1868) (@rikhuijzer)
- Server-side events as configuration (#1871) (@ctrekker)
- fix is_stdlib() for nightly and enable nightly tests (#1874) (@Pangoraw)
- Awesome! Line wrapping! (#1876) (@dralletje)
- respect maxlog keyword for logs, fixes #1858 (#1877) (@Pangoraw)
- allow .. as an identifier, fixes #1875 (#1878) (@Pangoraw)
- Server start event (#1882) (@ctrekker)
- Julia 1.6 minimum (#1885) (@fonsp)
- New heuristic to skip intermediate bond values (#1892) (@fonsp)
- Send queued bond changes when last script finishes (#1898) (@fonsp)

**Closed issues:**
- Pkg.jl will corrupt itself on Windows (#671)
- Failure creating JuMP DenseAxisArray (#806)
- Frontend tests fail too often (#1234)
- Open multiple notebooks at start and without browser (#1278)
- Segmentation faults on Julia 1.7 M1 (#1722)
- Table of content overlaps text in static HTML (#1770)
- Pluto hangs when cell contains `(md" ", md"$t")` (#1800)
- Cell drag drop broken in Linux Chrome v97 (#1809)
- Tables integration causes method ambiguities for `pluto_showable` (#1815)
- Segfault with CSV, SQLite, tables (M1) (#1842)
- Use RelocatableFolders.jl instead of project_relative_dir to allow sysimages (#1852)
- Logging doesn't respect `maxlog` (#1858)
- TOC in dark mode is still light when aside (#1860)
- ProgressLogging: suppressed logging in Turing.jl (#1862)
- Cannot update to version 0.17.7 (#1869)
- Stdlib packages marked as not found (#1872)
- EllipsisNotation.jl (`randn((10,10))[1, ..]`) does not work (#1875)
- Too many intermediate bond values (#1891)
@fonsp fonsp linked a pull request Feb 15, 2022 that will close this issue
Fix logging getting stuck when maxlog is specified and don't print maxlog, fixes #1902 #1911
Merged
@fonsp fonsp mentioned this issue Mar 2, 2022
Merged
@fonsp fonsp added the logging About `@info`, `@warn`, etc label Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
display & PlutoRunner & AbstractPlutoDingetjes.jl logging About `@info`, `@warn`, etc
Projects
None yet
Milestone
No milestone
3 participants
@fonsp @Joel-Dahne @roland-KA