Skip to content

Commit

Permalink
do not include plotly.jl twice (JuliaPlots#4684)
Browse files Browse the repository at this point in the history
* do not include plotly.jl twice

* remove plotly is_subplot_supported

* do not include plotly.jl  twice
  • Loading branch information
antholzer authored Mar 9, 2023
1 parent dd16078 commit 19657f3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
4 changes: 2 additions & 2 deletions src/backends.jl
Original file line number Diff line number Diff line change
Expand Up @@ -534,7 +534,7 @@ _post_imports(::PlotlyBackend) = @eval begin
const PlotlyKaleido = Main.PlotlyKaleido
# FIXME: in Plots `2.0`, `plotly` backend should be re-named to `plotlybase`
# so that we can trigger include on `@require` instead of this
include(_path(:plotly))
PLOTS_DEFAULT_BACKEND == "plotly" || include(_path(:plotly))
include(_path(:plotlybase))
end
function _initialize_backend(pkg::PlotlyBackend)
Expand All @@ -553,7 +553,7 @@ function _initialize_backend(pkg::PlotlyBackend)
# NOTE: `plotly` is special in the way that it does not require dependencies for displaying a plot
# as a result, we cannot rely on the `@require` mechanism for loading glue code
# this is why it must be done here.
@eval include(_path(:plotly))
PLOTS_DEFAULT_BACKEND == "plotly" || @eval include(_path(:plotly))
end
end

Expand Down
2 changes: 0 additions & 2 deletions src/backends/plotly.jl
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# https://plot.ly/javascript/getting-started

is_subplot_supported(::PlotlyBackend) = true
# is_string_supported(::PlotlyBackend) = true
_plotly_framestyle(style::Symbol) =
if style in (:box, :axes, :zerolines, :grid, :none)
style
Expand Down

0 comments on commit 19657f3

Please sign in to comment.