Skip to content

fix(lint): enable @typescript-eslint/triple-slash-reference rule - #3542

Open
lubber-de wants to merge 1 commit into
fomantic:developfrom
lubber-de:triple-slash-reference
Open

fix(lint): enable @typescript-eslint/triple-slash-reference rule#3542
lubber-de wants to merge 1 commit into
fomantic:developfrom
lubber-de:triple-slash-reference

Conversation

@lubber-de

Copy link
Copy Markdown
Member

Description

  • Enabled the typescript eslint rule @typescript-eslint/triple-slash-reference
  • rule "ban-types" does not exist in eslint 8 so i simply removed it inside this PR as well

@prudho @KiddoV You seem to be an active user of the types, so i would appreciate if you could test if the change to import will break anything (at least eslint is satisfied...)

@lubber-de lubber-de added this to the 2.10.0 milestone Jul 18, 2026
@lubber-de
lubber-de requested a review from prudho July 18, 2026 12:43
@lubber-de lubber-de added type/lint eslint / stylelint related changes only type/types Anything related to types labels Jul 18, 2026
@KiddoV

KiddoV commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Hi @lubber-de,

Sorry, it's been a while since I last checked on this library.

After updating my package.json from "fomantic-ui": "^2.9.4" to:

{
  "fomantic-ui": "github:lubber-de/Fomantic-UI#triple-slash-reference"
}

all of my ESLint checks started reporting the following error:

Property '___' does not exist on type 'JQuery<HTMLElement>'.

The application still runs, but I've run into a few issues:

  1. ESLint reports the error above for all Fomantic jQuery methods.
  2. All of my FUI icons are missing and are rendered as empty squares instead. (Not sure if this related?)

Am I missing an additional setup step after switching to this branch?

@lubber-de

lubber-de commented Jul 23, 2026

Copy link
Copy Markdown
Member Author

all of my ESLint checks started reporting the following error:

Property '___' does not exist on type 'JQuery<HTMLElement>'.

Very strange, if this (IMHO unrelated) change causes it for your code.

The application still runs, but I've run into a few issues:

  1. ESLint reports the error above for all Fomantic jQuery methods.

Again, thanks for testing, if eslint breaks for you because of this change, i'll put it this PR on hold.
I just wanted to make the eslinter happy at build time. Maybe prudho ran into a similar issue back then, when he invented the types, and therefore used the triple slash method.

  1. All of my FUI icons are missing and are rendered as empty squares instead. (Not sure if this related?)
    Am I missing an additional setup step after switching to this branch?

Not seeing the icons cannot be caused by this PR.
The develop branch aka nightly aka 2.10 beta, still uses the same FA icons as 2.9.4 does.
Only difference: We dropped IE, so the woff (not woff2) font files were removed. This probably causes it for you, if you still rely on them (?)

@lubber-de lubber-de added the state/on-hold Issues and pull requests which are on hold for any reason label Jul 23, 2026
@lubber-de lubber-de modified the milestones: 2.10.0, 2.10.x Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state/on-hold Issues and pull requests which are on hold for any reason type/lint eslint / stylelint related changes only type/types Anything related to types

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants