Replace new Function calls #29
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2018
|
Hope this gets through soon :/ @devongovett any chance to merge this one? |
|
Just wanted to mention that I applied these changes to my fork, which I'm using in pdf-lib@0.5.1 to allow pdf-lib to work on CSP sites. All of pdf-lib's tests pass, and it seems to be running just fine. I've published my fork to NPM as well, if anybody is interested in using it themselves: @pdf-lib/restructure. Version 0.0.0 includes just the changes from this PR. |
|
Any update on this? |
|
Is there any reason these changes haven't been incorporated into the code base? |
Member
|
Should be fixed by #34. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly improved change over the pull request
firien:remove-eval, tested against fontkit .new Functionis not allowed on sites with a Content Security Policy (CSP) and sane defaults.