Encrypt strings inside name trees - #1773
Open
klimeryk wants to merge 1 commit into
Open
Conversation
Fixes foliojs#1513 In an encrypted document, the strings inside name trees were being written unencrypted. PDF readers would then try to decrypt them like every other string, get garbage, and the lookup would fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1513
Ran into this while trying to add password support to my own project that uses pdfkit (well, a fork of it from @react-pdf/pdfkit): klimeryk/recalendar.js@f62f765. I'll be submitting the fix to them as well, but wanted to give back to the upstream first to verify the fix and make sure it's sound 🙇
In an encrypted document, the strings inside name trees are written unencrypted. Readers decrypt them like
every other string, get garbage, and the lookup fails. Anything that relies on a name tree is broken:
The cause is that
PDFObject.convert()discards the cipher for everyPDFTree, soPDFTree.toString()has nothing to pass on when it serialises/Limits, the keys and the values — and name tree keys are PDF strings.Checklist:
Tests:
tests/unit/tree.spec.js:The five encryption cases fail on
masterand pass with this change.Of course,
lint,formatand full tests pass as well.