Skip to content

Fix for FDArray parsing in CFF #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Fix for FDArray parsing in CFF #224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca89113
Fix FDArray parsing in CFF
liborm85 Apr 25, 2020
09f16e4
run test only if font available
liborm85 Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cff/CFFTop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,9 @@ class CFFPrivateOp {
let FontDict = new CFFDict([
// key name type(s) default
[18, 'Private', new CFFPrivateOp, null],
[[12, 38], 'FontName', 'sid', null]
[[12, 38], 'FontName', 'sid', null],
[[12, 7], 'FontMatrix', 'array', [0.001, 0, 0, 0.001, 0, 0]],
[[12, 5], 'PaintType', 'number', 0],
]);

let CFFTopDict = new CFFDict([
Expand Down
12 changes: 9 additions & 3 deletions test/subset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ describe('font subsetting', function() {
done();
}));
});

it('should re-encode variation glyphs', function(done) {
if (!fs.existsSync('/Library/Fonts/Skia.ttf')) return done();

let font = fontkit.openSync('/Library/Fonts/Skia.ttf', 'Bold');
let subset = font.createSubset();
for (let glyph of font.glyphsForString('e')) {
Expand Down Expand Up @@ -80,7 +80,13 @@ describe('font subsetting', function() {

it('should create a CFFSubset instance', function() {
let subset = font.createSubset();
return assert.equal(subset.constructor.name, 'CFFSubset');
assert.equal(subset.constructor.name, 'CFFSubset');

if (fs.existsSync('/Library/Fonts/PingFang.ttc')) {
let pingfang = fontkit.openSync('/Library/Fonts/PingFang.ttc', 'PingFangTC-Regular');
subset = pingfang.createSubset();
assert.equal(subset.constructor.name, 'CFFSubset');
}
});

it('should produce a subset', function(done) {
Expand Down