Skip to content

Use Promise instead of process.nextTick #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 17, 2019
Merged

Use Promise instead of process.nextTick #209

merged 1 commit into from
Nov 17, 2019

Conversation

@blikblum
Copy link
Member

@blikblum blikblum commented Oct 19, 2019

Removes dependency on node specific process.nextTick

@Pomax
Copy link
Contributor

Pomax commented Oct 21, 2019

Does this work, though? resolved is already resolved (by definition), so this will execute synchronously, not asynchronously.

@blikblum
Copy link
Member Author

blikblum commented Oct 21, 2019

Will Works. By Spec is async

@devongovett devongovett merged commit f2aa3d6 into foliojs:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devongovett devongovett devongovett approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@blikblum @Pomax @devongovett