Skip to content

Conversation

@issacgerges
Copy link
Contributor

In a recent Chromium upgrade, ligatures were disabled when letterspacing was non-zero. In order to match this behavior, we needed to add the ability to disable default AAT morx features.

I've added a test for this case and validated it does allow us to disable ligatures with non-zero letterspacing but I'm not a font expert and want to validate this won't introduce any issues.

Here's a snippet

let glyphRun;
if (characterSpacing === 0) {
   glyphRun = fontkitFont.layout(text);
} else {
   glyphRun = fontkitFont.layout(text, { liga: false });
}

and the resulting output

image

Copy link
Member

@devongovett devongovett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Should we also support this for OpenType?

@devongovett devongovett merged commit 9d41540 into foliojs:master Oct 6, 2019
@issacgerges
Copy link
Contributor Author

Thanks for merging @devongovett. When do ya'll normally run releases? I can also look into what might need to be done to support this on OpenType (or if it works already)

@issacgerges
Copy link
Contributor Author

issacgerges commented Oct 15, 2019

Looks good! Should we also support this for OpenType?

Looks like that is already working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants