STRWEB-111 Refresh PostCSS stack. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
LGTM. Thank you!
strip out imports of variables to prevent variable reset via a custom postcss plugin.
This seems like a great idea. Also seems like maaaybe a change in behavior that we need to tell people about? Or is it more like, "Finally prevent people from doing things they shouldn't have been doing in the first place" so we don't need to worry about telling anybody?
|
@zburke yes - this is something worth telling folks - that they can just strip out their imports since now both variables and custom media queries are accounted for. I will roll a stripes-update message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-empting a tighter build process with pre-transpilations, we want to ensure purity in our CSS so that we reduce the amount of discrepency between builds performed at separate locations in the code, in separate repos, etc.
This PR removes unnecessary postcss plugins that have already been implemented in native CSS. This includes:
&'s in our styles)Additionally, this PR respects standard CSS Variable treatment - render once, use throughout codebase. Imports of CSS variables from stripes-components have been filtered out, and the global set are injected via a additional entry point (alongside
global.cssin the base webpack configuration.)I've added on a single postcss-dependency:
postcss-global-datafor usage in conjunction withpostcss-custom-media. Stripes' CSS variables and custom media variables existed within the same file. UI modules would need to import the file because of the custom media variables. However, if variables are injected viapostcss-global-dataui-modules will no longer have to import the variables for them to be used.All modules and components can remove imports to
variables.cssfromstripes-components.With this standard treatment of CSS variables, the gates are also open for a clean implementation of theming...