MODNCIP-71: Upgrade dependencies for Ramsons #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianladisch
force-pushed
the
MODNCIP-71-dependencies-ramsons
branch
from
5ef462d
to
792c624
Compare
https://folio-org.atlassian.net/browse/MODNCIP-71 In MainVerticleTest.java: Replace the deprecated deployVerticle method that will be removed in Vert.x 5: Don't use the callback method, use the Future returning method instead: https://github.com/eclipse-vertx/vert.x/wiki/Vert.x-5#callback-sanitization https://github.com/folio-org/raml-module-builder/blob/master/doc/futurisation.md Replace the custom success method with Vert.x' ctx.asyncAssertSuccess that provides the same functionality: https://vertx.io/docs/vertx-unit/java/#_asynchronous_assertions
julianladisch
force-pushed
the
MODNCIP-71-dependencies-ramsons
branch
from
da228a4
to
281c51a
Compare
|
JanisSaldabols
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://folio-org.atlassian.net/browse/MODNCIP-71