Update 'Not-Worked Only' filter logic and label #836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified the SQL HAVING clause to include cases where SUM(d.'band') equals 1, allowing filtering for both not-worked and not-confirmed entries. Updated the checkbox label in the UI to reflect this expanded filter.
Split the previous Not-Worked/Not-Confirmed Only checkbox into two distinct checkboxes in the AwardsDialog UI. Updated SQL query logic to support independent filtering for Not-Worked and Not-Confirmed entities, and connected the new checkbox to refresh the table on state change.
Author
|
Ok I added as a separate checkboxes. The labels may need to be tweaked to better explain or a tooltip. But the logic is there. |
Owner
|
I liked the first idea with a single checkbox better, but I have nothing against your second option. Thank you. |
Owner
|
I simplified it a bit. Could you take a look to see whether I made any logical mistakes? It seems to me that it might work - branch |
Author
|
Looks good to me. Works as expected. Thank you @foldynl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#835 Modified the SQL HAVING clause to include cases where SUM(d.'band') equals 1, allowing filtering for both not-worked and not-confirmed entries. Updated the checkbox label in the UI to reflect this expanded filter.