Skip to content

Conversation

@BG7JAF
Copy link

@BG7JAF BG7JAF commented Nov 30, 2024

RT

@foldynl
Copy link
Owner

foldynl commented Dec 1, 2024

thank you

@BG7JAF
Copy link
Author

BG7JAF commented Dec 2, 2024

Due to some known reasons, there‘s problems for Chinese users accessing OpenStreet's servers, so I added the map source of autonavi, a domestic map service provider in China. The new map source also enhances the user experience for Chinese users.

@foldynl
Copy link
Owner

foldynl commented Dec 2, 2024

I have two comments:

  1. Please avoid combining multiple changes into a single PR. I will split this PR for now, but keep this in mind for the future.

  2. Since I don’t understand Chinese, I cannot verify whether this change is suitable for an open-source project. Specifically, I can't determine if it’s free of restrictions or potential regulatory issues. Therefore, unfortunately, I cannot accept the map change.

Translation file will be a part of the next release.

@BG7JAF
Copy link
Author

BG7JAF commented Dec 3, 2024

  1. Got that. that's my mistake.
  2. I will ask autonavi about legal issues related to open-source projects that use its services. If it is legal, I will submit the relevant proof and code again.

@foldynl
Copy link
Owner

foldynl commented Jan 11, 2025

v0.41 includes the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done - branch: testing_0.41

Development

Successfully merging this pull request may close these issues.

2 participants