Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new CLI flags #356

Merged
merged 4 commits into from
Jun 4, 2024
Merged

new CLI flags #356

merged 4 commits into from
Jun 4, 2024

Conversation

fohrloop
Copy link
Owner

@fohrloop fohrloop commented Jun 4, 2024 •
edited
Loading

Closes: #355

The wakepy Modes are keep.running and keep.presenting.

The CLI options are:

-k, --keep-running
-p, --presentation

For consistency, changed the new CLI flags to be:

-r, --keep-running
-p, --keep-presenting

The old ones will raise a DeprecationWarning when used.

@fohrloop fohrloop merged commit 083a75a into main Jun 4, 2024
14 checks passed
@fohrloop fohrloop deleted the issue-355-cli-args-naming-convention branch June 8, 2024 19:07
@fohrloop fohrloop mentioned this pull request Sep 19, 2024
Merged
fohrloop added a commit that referenced this pull request Sep 19, 2024
@fohrloop
Rename the CLI flags: Addendum to PR 356 (#391)
eefc7ce 
Amends: #356
Relates to issue: #355

- Update CLI API docs
- Use print() instead of DeprecationWarning, as DeprecationWarnings are
  not printed to standard output by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename the CLI flags: Have same naming convention everywhere. --keep-presenting and -r
1 participant
@fohrloop