Skip to content

Check errors from Close method in SavePNG and SaveJPG #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peterstace wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Check errors from Close method in SavePNG and SaveJPG #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,10 @@ func SavePNG(path string, im image.Image) error {
if err != nil {
return err
}
defer file.Close()
return png.Encode(file, im)
if err := png.Encode(file, im); err != nil {
return err
}
return file.Close()
}

func LoadJPG(path string) (image.Image, error) {
Expand All @@ -68,12 +70,14 @@ func SaveJPG(path string, im image.Image, quality int) error {
if err != nil {
return err
}
defer file.Close()

var opt jpeg.Options
opt.Quality = quality

return jpeg.Encode(file, im, &opt)
if err := jpeg.Encode(file, im, &opt); err != nil {
return err
}
return file.Close()
}

func imageToRGBA(src image.Image) *image.RGBA {
Expand Down