Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My use-case is to create an educational video where I want to explain an algorithm that works on images.
I would like to start the video by zooming into an image until we can see the pixels. However, in gg I get a blurry image when zooming in.
By default gg uses the draw package's BiLinear interpolation. This PR adds SetScaleStyle which I use to adjust the interpolation dynamically. While the image in my video is zoomed out, it is linearly interpolated. But once the zoom level is > 1, I switch to NearestNeighbor to show the pixels.
I have tried to keep this in line with the rest of the code, adding SetScaleStyle with a parameter and concrete SetScaleBiLinear etc. for easier auto-completion (if that is your reasoning, makes sense to me at least).