Skip to content

Conversation

@sethboyles
Copy link
Contributor

the URI constant DEFAULT_PARSER changed in newer versions of URI. I didn't see a simple backwards compatible way to reference the old constant, so I've inlined the regex

I'm open to cleaner ways of doing this.

the URI constant DEFAULT_PARSER changed in newer versions of URI.  I didn't see a simple backwards compatible way to reference the old constant, so I've inlined the regex
@sethboyles
Copy link
Contributor Author

@geemus could we have this merged in/released? thanks

@geemus geemus merged commit b0bbb47 into fog:master Mar 20, 2025
@geemus
Copy link
Member

geemus commented Mar 20, 2025

oops, I didn't realize but apparently I hadn't had watch set on this repo, so I was unaware. Just tried to play catch up on that, so I merged everything in the queue, got CI green again and released v0.9.0

@sethboyles
Copy link
Contributor Author

awesome, thanks!

@BrianHawley
Copy link

BrianHawley commented Apr 16, 2025

@sethboyles URI::RFC2396_PARSER.regexp[:UNSAFE] should be a backwards-compatible way to reference the old constant. I've been using it in a patch ever since uri 1.0 came out. Just FYI. Probably better to inline it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants