Merged
Conversation
michael-w-williams
requested review from
carimura,
sachin-pikle,
shaunsmith and
treeder
sachin-pikle
approved these changes
Mar 8, 2018
Contributor
sachin-pikle
left a comment
sachin-pikle
left a comment
There was a problem hiding this comment.
Looks great to me. I ran the commands using the latest CLI (0.4.63) and server (0.3.355) and it worked fine. (I have an unrelated thread in Slack about the size of the go "dev" image.)
carimura
reviewed
Mar 8, 2018
Introduction/README.md
Outdated
| ``` | ||
|
|
||
| You can see the `func.yaml` contents by typing: | ||
| This function looks for JSON input in the form of `{"name", "Bob"}`. If this |
Member
There was a problem hiding this comment.
typo:
have {"name", "Bob"}
should be {"name": "Bob"}
Member
Author
|
Fixed the Bob json typo. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've updated the introduction tutorial to use the FDK generated func.go function. Took a bit longer than I thought to change the function name (gofn) and and app name (goapp). Might need to do some word smithing in middle of the tutorial as the JSON changed that part quite a bit.