Skip to content

Commit

Permalink
Prefer english constants to perl symbols (style).
Browse files Browse the repository at this point in the history
  • Loading branch information
fnichol committed Aug 5, 2014
1 parent 8a03597 commit 1a79977
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion emeril.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
lib = File.expand_path('../lib', __FILE__)
$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
require 'emeril/version'
require "English"

Gem::Specification.new do |spec|
spec.name = "emeril"
Expand All @@ -13,7 +14,7 @@ Gem::Specification.new do |spec|
spec.homepage = "http://fnichol.github.io/emeril/"
spec.license = "MIT"

spec.files = `git ls-files`.split($/)
spec.files = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
spec.executables = []
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]
Expand Down
6 changes: 4 additions & 2 deletions lib/emeril/git_tagger.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# -*- encoding: utf-8 -*-

require "English"

require 'emeril/logging'

module Emeril
Expand Down Expand Up @@ -100,11 +102,11 @@ def sh_with_code(cmd, &block)
debug(cmd)
Dir.chdir(source_path) {
outbuf = `#{cmd}`
if $? == 0
if $CHILD_STATUS == 0
block.call(outbuf) if block
end
}
[outbuf, $?]
[outbuf, $CHILD_STATUS]
end

def tag_version
Expand Down

0 comments on commit 1a79977

Please sign in to comment.