Added Otter Browser detection. #310
Conversation
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
lib/browser/base.rb
Outdated
| @@ -179,5 +179,10 @@ def proxy? | |||
| def electron?(expected_version = nil) | |||
| Electron.new(ua).match? && detect_version?(full_version, expected_version) | |||
| end | |||
|
|
|||
lib/browser/otter-browser.rb
Outdated
| @@ -0,0 +1,21 @@ | |||
| # frozen_string_literal: | |||
lib/browser/otter-browser.rb
Outdated
| # frozen_string_literal: | ||
|
|
||
| module Browser | ||
| class OtterBrowser < Base |
There was a problem hiding this comment.
Similar code found in 8 other locations (mass = 21) (lib/browser/otter-browser.rb#4, lib/browser/alipay.rb#4, lib/browser/electron.rb#4, lib/browser/firefox.rb#4, lib/browser/micro_messenger.rb#4, lib/browser/nokia.rb#4, lib/browser/phantom_js.rb#4, lib/browser/uc_browser.rb#4, and lib/browser/weibo.rb#4)
|
I don't understand it… |
Signed-off-by: Marcin Mikołajczak <me@m4sk.in>
|
|
||
| # Detect if browser is Otter Browser. | ||
| def otter_browser?(expected_version = nil) | ||
| OtterBrowser.new(ua).match? && detect_version?(full_version, expected_version) |
| # frozen_string_literal: true | ||
|
|
||
| module Browser | ||
| class OtterBrowser < Base |
There was a problem hiding this comment.
Similar code found in 8 other locations (mass = 21) (lib/browser/otter_browser.rb#4, lib/browser/alipay.rb#4, lib/browser/electron.rb#4, lib/browser/firefox.rb#4, lib/browser/micro_messenger.rb#4, lib/browser/nokia.rb#4, lib/browser/phantom_js.rb#4, lib/browser/uc_browser.rb#4, and lib/browser/weibo.rb#4)
|
Ebert has finished reviewing this Pull Request and has found:
You can see more details about this review at https://ebertapp.io/github/fnando/browser/pulls/310. |
Signed-off-by: Marcin Mikołajczak me@m4sk.in