Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Electron Framework #305

Merged
merged 3 commits into from
Jun 29, 2017
Merged

Conversation

andreimoldo
Copy link
Contributor

Electron based apps are currently marked as Chrome (which is correct), but there needs to be a way to tell them apart.

@fnando
Copy link
Owner

fnando commented Jun 7, 2017

Hello, @andreimoldo! This is your first Pull Request that will be reviewed by Ebert, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information.

# frozen_string_literal: true

module Browser
class Electron < Base
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fnando
Copy link
Owner

fnando commented Jun 7, 2017

Ebert has finished reviewing this Pull Request and has found:

  • 1 possible new issue (including those that may have been commented here).

You can see more details about this review at https://ebertapp.io/github/fnando/browser/pulls/305.

@fnando fnando merged commit 95f4d88 into fnando:master Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants