Name namespace-scope unscoped enums#4838
Open
avikivity wants to merge 1 commit into
Open
Conversation
Unnamed unscoped enums at namespace scope are problematic (llvm/llvm-project#207581). Giving each such enum a name (derived from the constant it declares) is enough to avoid the issue, so do that for the header-level integral constants instead of leaving them anonymous. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
avikivity
force-pushed
the
unscoped-enums-bad
branch
from
dc8beff to
649ae19
Compare
Author
|
Update:
|
avikivity
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unnamed unscoped enums at namespace scope are problematic
(llvm/llvm-project#207581). Giving each such
enum a name (derived from the constant it declares) is enough to avoid
the issue, so do that for the header-level integral constants instead of
leaving them anonymous.