Move export() directive outside of FMT_INSTALL scope#4827
Open
RealSteel99-codes wants to merge 1 commit into
Open
Move export() directive outside of FMT_INSTALL scope#4827RealSteel99-codes wants to merge 1 commit into
RealSteel99-codes wants to merge 1 commit into
Conversation
vitaut
requested changes
Jun 28, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Mostly looks good but please fix the formatting (see CI error).
vitaut
requested changes
Jul 5, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
Please fix formatting (see lint) and address the inline comment
Comment on lines
507
to
508
| # Use a namespace because CMake provides better diagnostics for namespaced | ||
| # imported targets. |
Contributor
There was a problem hiding this comment.
This should be move to the new export location too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4806