avoid MSC warning C4702: unreachable code#4822
Merged
Merged
Conversation
Skylion007
approved these changes
Jul 1, 2026
if FMT_CONSTEXPR is resolved to constexpr MSC warns about dead code after 'return' instruction. Explicitly using 'else' in these cases avoids the warning.
vitaut
approved these changes
Jul 3, 2026
vitaut
left a comment
vitaut
left a comment
Contributor
There was a problem hiding this comment.
In general we don't care about level 4 MSVC warnings because of their very low quality but I think this particular change is relatively small scope so I'm OK merging it.
pull Bot
pushed a commit
to TheDegenerateDev5150/fmt
that referenced
this pull request
Jul 4, 2026
Revert the explicit-else workaround from fmtlib#4822 and instead disable the "unreachable code" warning for all of base.h. Add an FMT_PRAGMA_MSVC helper (mirroring FMT_PRAGMA_GCC/CLANG) and wrap the header in a single warning(push)/disable:4702/pop pair, keeping the original control flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if FMT_CONSTEXPR is resolved to constexpr MSC warns about dead code after 'return' instruction. Explicitly using 'else' in these cases avoids the warning.